Upgrade ava and meow
#49
Conversation
There was a problem hiding this comment.
Thank you for the PR! I'd ask you two things:
- move the AVA upgrade into a separate PR (because it means converting the module into ESM) or drop the update altogether since it's not user-facing
- remove the lockfile since it does not affect npm users
I've been wanting to make a release but I've been swamped.
If you'd like to update every dependency feel free to (except the ones that require ESM, unless you also convert it to ESM), but make sure you're testing the package first.
| import stubs from './helpers/stubs'; | ||
| const test = require('ava'); | ||
| const util = require('../util'); | ||
| const stubs = require('./helpers/stubs'); |
There was a problem hiding this comment.
These should not be changed but instead the the rest of the module should be turned into ESM (only).
There was a problem hiding this comment.
move the AVA upgrade into a separate PR (because it means converting the module into ESM)
Given that (as far as I can tell, anyway) this syntax does work, couldn't converting everything to ESM come later?
There was a problem hiding this comment.
I'd rather not have to change everything to CJS and then back to ESM, but I think it's ok
|
Cheers April! |
|
Since this increases the minimum node version to v12 it will be released as a breaking release in a few days. Feel free to update any other dependencies before then. |
|
v2.0.0 has been published: https://github.com/fregante/chrome-webstore-upload-cli/releases/tag/v2.0.0 It'd be great if you could test it as well and let me know if it still works without having to change any keys. |
|
Yep, my existing keys seem to work just fine! |
Upgrading to
ava@latestandmeow@v9eliminates all npm vulnerability warnings. Somehow I was under the impression that there were none following merge of #47, probably due to my hesitance to commit the lockfile, which I have done here.