Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept the new token format in the options #46

Merged
merged 4 commits into from
Mar 5, 2021

Conversation

ckzhang26
Copy link
Contributor

@ckzhang26 ckzhang26 commented Mar 5, 2021

Fixes #45

The new pattern matches the prefix for Personal Access Tokens. It will also accept the new token length of up to 255 characters after June 1.

source/options.html Outdated Show resolved Hide resolved
source/options.html Outdated Show resolved Hide resolved
@fregante fregante changed the title 45 New GitHub Token Format Accept the new token format in the options Mar 5, 2021
@fregante fregante merged commit 03b8941 into fregante:master Mar 5, 2021
@fregante
Copy link
Owner

fregante commented Mar 5, 2021

Congrats @ckzhang26 on the most approved PR in this repo!

@fregante fregante added the meta label Mar 5, 2021
@ckzhang26
Copy link
Contributor Author

Thanks everyone for the help! This was my first issue and open source contribution 😅

@fregante
Copy link
Owner

fregante commented Mar 5, 2021

There's another project that needs the same treatment, if you'd like ;)

https://github.com/sindresorhus/refined-github/blob/main/distribution/options.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New GitHub tokens are not accepted by the options form
4 participants