Color closed issues purple and update classes #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you follow the linter as well? |
|
@cheap-glitch are these still the right classes? |
No, you want to use Also |
|
We can leave the current classes and add those as well, just to ensure GHE compat since it's easy (I still have the original |
Merged
Yash-Singh1
changed the title
fregante
changed the title
|
Thank you @Yash-Singh1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, a bit of a refactor to the state color map to make it less complicated when adding more states for types. I don't know if this is related to my changes, but when I ran the extension locally, it seemed to not show the purple color for the links to closed issues. Looking at some screenshots and issues, this seems to be the current behavior. Is this expected?
Fixes #64