Exclude encrypted/wan interfaces in OWM info #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -344,6 +351,10 @@ function get() | |||
| if 'lo' == vif.ifname then | |||
| return | |||
| end | |||
| if 'br-wan' == vif.ifname then | |||
There was a problem hiding this comment.
I think vif.name should be checked against wan and wan6 here.
|
Thanks for the PR! The encryption check looks good. Can you update the PR with an adapted wan check? |
wan contains info about the node owner's private network or possibly even info about the ISP (for direct connections to a cable/DSL modem).
|
Thanks. There. :) |
|
Works nicely on my router. |
andrenarchy
added a commit
that referenced
this pull request
Feb 1, 2015
Exclude encrypted/wan interfaces in OWM info
|
Thx for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See freifunk-berlin/firmware#206 .
This patch is intended to prevent owm.lua from pushing information about a) private encrypted wifi networks and b) the local WAN port configuration to the public.
Ultimatively, I think there should be a user-configurable whitelist instead of a blacklist, and some "show me what information gets published beforehand" functionality, but this is way too much effort with libremap coming.