Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tunneldigger to the default and backbone images #701

Closed
wants to merge 1 commit into from

Conversation

pmelange
Copy link
Contributor

This addresses issue #690 where a node which has been set up to
use the bbbdigger package cannot connect to the bbb-vpn server after
a firmware upgrade.

Additionally, this has been agreed upon at the firmware planning meeting 12.06.2019 https://pad.freifunk.net/p/berlin-2019

This addresses issue #690 where a node which has been set up to
use the bbbdigger package cannot connect to the bbb-vpn server after
a firmware upgrade.
@pmelange
Copy link
Contributor Author

This commit has been cherry-picked into Gonzo-1.1.0-rc1. It would be great if these changes were merged into the master branch.

@pmelange
Copy link
Contributor Author

This PR is dependant on freifunk-berlin/firmware-packages#189 being merged as well.

@SvenRoederer
Copy link
Contributor

I personally don't like this idea.
Beside this it looks like this change will enable the bbbdigger link on all these nodes (https://github.com/freifunk-berlin/firmware-packages/blob/master/addons/freifunk-berlin-bbbdigger/files/postinst.sh#L46). I don't think this is intended

@pmelange
Copy link
Contributor Author

But the package freifunk-berlin-bbbdigger is not installed on any of the images.

@SvenRoederer
Copy link
Contributor

Ah, got it ...
But does adding it to the "backbone"-image really makes sense? As backbone implies it's a node with real backbone-connectivity, so a backbone-tunnel might not be useful there.

@pmelange
Copy link
Contributor Author

I feel that the name 'backbone' is an inadequate name for the image. It should be something more like 'expert mode' or 'manual configuration'. I personally have used it for a core router where using the wizard didn't make sense. That same router also connects to the bbbvpn.

@pmelange
Copy link
Contributor Author

Also, there is at least one node on the backbone which also has a link to the bbb-vpn (mod77uplink.olsr). This could be useful for situations where the link to the real backbone goes down and then the only way to access the node would be through the bbbvpn.

@SvenRoederer
Copy link
Contributor

Using a unique single example of mod77uplink seems not a strong argument.

regarding the naming: I think there is an issue dealing with naming changes. I think now it the right time to change the naming.

@SvenRoederer
Copy link
Contributor

Please check #713 regarding the naming-change. I had a change ready in my branch already.

@@ -73,3 +73,6 @@ collectd-mod-rrdtool
collectd-mod-ping
collectd-mod-uptime
collectd-mod-memory

# Tunneldigger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you note like "# Tunneldigger to resume VPN after flashing"

@@ -83,3 +83,6 @@ collectd-mod-rrdtool
collectd-mod-ping
collectd-mod-uptime
collectd-mod-memory

# Tunneldigger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment for the backbone-image

@SvenRoederer SvenRoederer added this to To do in Release 2021.x May 18, 2020
@pmelange pmelange closed this Aug 9, 2020
Release 2021.x automation moved this from To do to Done Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants