batman-adv: Fix best gw refcnt after netlink dump #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecsv
force-pushed
the
batadv/gw_refcnt_fix
branch
from
1aed0f7
to
25dc592
Compare
A reference to the best gateway is taken when the list of gateways in the
mesh is sent via netlink. This is necessary to check whether the currently
dumped entry is the currently selected gateway or not. This information is
then transferred as flag BATADV_ATTR_FLAG_BEST.
After the comparison of the current entry is done,
batadv_*_gw_dump_entry() has to decrease the reference counter again.
Otherwise the reference will be held and thus prevents a proper shutdown of
the batman-adv interfaces (and some of the interfaces enslaved in it).
Fixes: 899235a4a637 ("Merge pull request freifunk-gluon#241 from ecsv/batman-adv-2016.4-maint-2016-10-29")
Reported-by: Andreas Ziegler <dev@andreas-ziegler.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
ecsv
force-pushed
the
batadv/gw_refcnt_fix
branch
from
25dc592
to
81d7c30
Compare
|
i tested this by using your branches: |
rotanid
approved these changes
Jun 3, 2018
|
Thanks for finding and fixing this! |
|
Was this bug also present in 2016? |
|
@rubo77 no. |
SvenRoederer
added a commit
to SvenRoederer/freifunk-gluon_core
that referenced
this pull request
Sep 29, 2019
d2dc32a luci-app-statistics: set logfile as first item in collectd.conf a9bddc4 timezone data: update to 2017c 07e7ff0 Fixes freifunk-gluon#1413. b74ef26 Merge pull request freifunk-gluon#1411 from Cye3s/lede-17.01 4a0877b luci_base: Update zh_TW base.po, translate fix 1aae4e9 luci_base: Update zh_CN base.po, translate fix 0ed8086 Merge pull request freifunk-gluon#1403 from StevenHessing/lede-17.01-noddos d685c23 luci-app-noddos: backport from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem similar to the one described in #1258.
This patch will not apply on 2017.1.x. An adjusted version can be found in https://github.com/FreifunkVogtland/gluon/tree/batadv/gw_refcnt_fix-2017.1.x
A reference for the best gateway is taken when the list of gateways in the mesh is sent via netlink. This is necessary to check whether the currently dumped entry is the currently selected gateway or not. This information is then transferred as flag BATADV_ATTR_FLAG_BEST.
After the comparison of the current entry is done, batadv_*_gw_dump_entry() has to decrease the reference counter again. Otherwise the reference will be held and thus prevents a proper shutdown of
the batman-adv interfaces (and some of the interfaces enslaved in it).