Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: site: pubkey_privacy works for wireguard #3254

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

Djfe
Copy link
Contributor

@Djfe Djfe commented May 10, 2024

I removed a comment from the site documentation citing, that fastd is the only vpn where pubkey_privacy has an effect.
I just verified by editing /lib/gluon/site.json and running gluon-reconfigure and reboot, that this settings also works for wireguard VPNs.

I'm not sure whether it works for Tunneldigger, so this documentation change requires further feedback.
Is there a fourth VPN provider we support?

@github-actions github-actions bot added the 3. topic: docs Topic: Documentation label May 10, 2024
Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only support fastd and wireguard.
So the removal of this line is correct, as all two supported VPNs do support this option.

@blocktrron
Copy link
Member

Please remove the Draft state and we can get this merged.

@blocktrron blocktrron added the 2. status: waiting-on-author Waiting on some action from the author label Jun 9, 2024
@Djfe Djfe marked this pull request as ready for review June 9, 2024 01:59
@blocktrron blocktrron merged commit 068c12b into freifunk-gluon:master Jun 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. status: waiting-on-author Waiting on some action from the author 3. topic: docs Topic: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants