Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for TP-Link WR843ND #634

Merged
merged 1 commit into from Jan 30, 2016

Conversation

Ranlvor
Copy link
Contributor

@Ranlvor Ranlvor commented Jan 29, 2016

Tests done to verify that this worked as intended:

  • checked plattform_info image_name
  • checked primary_mac
  • does appear in ffmap-d3
  • does mesh
  • does fastd-VPN

Tests done to verify that this worked as intended:
 * checked plattform_info image_name
 * checked primary_mac
 * does appear in ffmap-d3
 * does mesh
 * does fastd-VPN
@rotanid
Copy link
Member

rotanid commented Jan 29, 2016

reading your Pull Request i noticed, that there are some models like your 843 and 842 and 1043 which have a "N/ND" in their description/comment, although there are only the ND ones available on TP-Links website and everywhere else.
if no one objects, i can prepare a pull request which changes this to "ND" only.

@Ranlvor
Copy link
Contributor Author

Ranlvor commented Jan 29, 2016

This N/ND-Stuff is weird. For example my code says

tl-wr843nd-v1,tp-link-tl-wr843n-nd-v1

because the OpenWRT-Image is called nd-v1 while the autoupdater expects an image to be called n-nd-v1 according to the output of

lua -e 'print(require("platform_info").get_image_name())'

To your proposed Pull Request: The software doen't realy seem to care about the N/ND-difference and so do I.

@rotanid
Copy link
Member

rotanid commented Jan 29, 2016

this is cosmetic, so i don't insist on changig that, if @NeoRaider voices reasons not to do it

neocturne added a commit that referenced this pull request Jan 30, 2016
Added Support for TP-Link WR843ND
@neocturne neocturne merged commit 4bfdd50 into freifunk-gluon:master Jan 30, 2016
ecsv pushed a commit to FreifunkVogtland/gluon that referenced this pull request Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants