gluon-config-mode-contact-info: an "obligatory" option in site.conf #843

rubo77 · 2016-08-04T09:15:26Z

We already have a useable stand-alone packet to replace the gluon-config-mode-contact-info package in our repository at:

https://github.com/freifunk-kiel/ffki-packages/tree/master/gluon-config-mode-contact-obligatory

kb-light · 2016-08-04T10:54:12Z

First package/gluon-config-mode-contact-info/files/lib/gluon/config-mode/wizard/0500-contact-info.lua can actually be found as: package/gluon-config-mode-contact-info/luasrc/lib/gluon/config-mode/wizard/0500-contact-info.lua.

Second, I think the fact that the owner information is public is a reason why you do not want to have this as "obligatory" but let the people decide on their own.

rubo77 · 2016-08-04T11:54:09Z

So what exactly do I have to change in the makefile to get this accepted? is it this part here? https://github.com/freifunk-gluon/gluon/pull/843/files#diff-83df6372edb9e411399cb8c89df9d143R32

second: obligatory in this package only means, that you have to fill in anything (even just a space is ok if you want to stay anonymous)

rotanid · 2016-08-04T11:56:57Z

nice @rubo77 , we're planning on doing something similar, having a "are you sure you want to leave the contact field empty? ..." message appear, so the people installing nodes at least don't forget it by accident.
forcing will probably result in many contact-informations that are wrong on purpose...
what do you think?

@kb-light well, one could argue the PPA specifices you have to be reachable as a node operator..

rotanid · 2016-08-04T12:01:01Z

@rubo77 regarding what @kb-light said: you put the 0500-contact-info.lua in the wrong folder, it switched places a while ago, please edit it in the new location rather than adding it to the old location.

rubo77 · 2016-08-04T12:05:11Z

@rotanid, good idea. Did you create a packet for this already? I added the standalone packet, we already tested in the first message.

We assume, that at the moment many users keep the contact field empty, cause of laziness or they want to fill it out later, but never find the time. only a small fraction doesn't want to be reachable.

I also thought of an option like:

[x] I would like to be notified, if my node is offline

... tell us how to reach you by the contact field or a private email or an online nodewatcher system, that will be available soon

I think, if a popup asks for confirmation to leave the field empty is not strong enough. If the field is obligatory, we get a better hint in the json string, that the user really wants to be anonymous, and didn't just forget or postponed to enter anything.

rotanid · 2016-08-04T12:54:28Z

package/gluon-config-mode-contact-info/files/lib/gluon/config-mode/wizard/0500-contact-info.lua

@@ -0,0 +1,35 @@
+local cbi = require "luci.cbi"


this whole file is in the wrong folder, a while ago it switched places, maybe you started your development based on an older revision of gluon.

jplitza · 2016-08-05T17:28:57Z

@rubo77 Such a checkbox doesn't really make sense, because to spam an address you have to have confirmed opt-in by that person, meaning that you also verified the opt-in really came from the owner of the address. So if you have a monitoring solution, simply let it send an "You're node went down for the first time, do you want to receive such notices in the future?". (I think you're using my nodewatcher? That still has to be implemented there.)

rubo77 · 2016-08-05T22:53:42Z

I moved files/lib/gluon/config-mode/wizard/0500-contact-info.lua to luasrc/lib/gluon/config-mode/wizard/0500-contact-info.lua and added the ending linebreak.

anything else?

kb-light · 2016-08-07T08:20:14Z

...age/gluon-config-mode-contact-info/luasrc/lib/gluon/config-mode/wizard/0500-contact-info.lua

      .. 'this information will be visible <em>publicly</em> '
      .. 'on the internet together with your node\'s coordinates.'
    )
  )

  local o = s:option(cbi.Value, "_contact", i18n.translate("Contact info"))
  o.default = uci:get_first("gluon-node-info", "owner", "contact", "")
-  o.rmempty = true
+  o.rmempty = not site.owner.obligatory


Have you tested this in case owner is not set within site.conf

yes.
it worked as false (or nil), anyway, it worked fine. I guess lua does automatic typecasting in case it is nil

if obligatory is not set everything works fine, but in case owner is not set, there will be an error: attempt to index field 'owner' (a nil value)
So you should change this to: o.rmempty = not (site.owner or {}).obligatory

ok, since I refactored the option to site.config_mode.owner.obligatory I changed this to

o.rmempty = not ((site.config_mode or {}).owner or {}).obligatory

rotanid · 2016-08-08T01:42:35Z

docs/site-example/site.conf

@@ -181,13 +181,18 @@

  -- Skip setup mode (config mode) on first boot
  -- setup_mode = {
-  --  skip = true,
+  --   skip = true,


there really is a space missing, but that has nothing to do with this pull request

should I revert this correction then? or just leave it, as minor, uninteresting side-fix ;-)

neocturne · 2016-08-28T02:10:17Z

package/gluon-config-mode-contact-info/Makefile

@@ -13,10 +13,15 @@ PKG_CONFIG_DEPENDS += $(GLUON_I18N_CONFIG)
 define Package/gluon-config-mode-contact-info
  SECTION:=gluon
  CATEGORY:=Gluon
-  TITLE:=Set a custom string that will be distributed in the mesh.
+  TITLE:=Set a custom string for a contact info that will be distributed in the mesh.


"for a contact info" sounds weird, "information" is always plural. Also the whole sentence doesn't make a lot of sense.

Maybe "Allows the user to provide contact information to be distributed in the mesh"

rubo77 · 2016-08-30T12:17:03Z

Ich hab den Satz noch mal überarbeitet:

+"Bitte hinterlege hier einen <em>öffentlichen</em> Hinweis, um anderen "
+"zu ermöglichen, Kontakt mit dir aufzunehmen. Beachte, dass "
+"dieser Hinweis zusammen mit den Koordinaten deines Knotens öffentlich "
+"im Internet einsehbar sein wird."

neocturne · 2016-08-30T20:04:54Z

Das klingt jetzt seltsam, als könnte man auch einen nicht öffentlichen Hinweis hinterlegen... Vielleicht das erste "öffentlich" streichen und statt dessen das zweite (oder sogar "öffentlich im Internet") hervorheben?

rubo77 · 2016-09-01T11:37:18Z

"Bitte hinterlege hier einen Hinweis, wie andere mit dir Kontakt aufnehmen "
"können. Beachte dass dieser Hinweis zusammen mit den Koordinaten deines "
"Knotens <em>öffentlich</em> im Internet einsehbar sein wird."

neocturne · 2016-09-01T13:36:11Z

package/gluon-config-mode-contact-info/Makefile

  DEPENDS:=gluon-config-mode-core-virtual +gluon-node-info
 endef

+define Package/gluon-config-mode-contact-info/description
+	Set a custom string for a contact info that will be distributed in the mesh.


You updated the TITLE, but left the "a contact info" in the description.

rubo77 · 2016-09-01T16:27:38Z

OK, so?

"Bitte hinterlege hier einen Hinweis, um anderen "
"zu ermöglichen, Kontakt mit dir aufzunehmen. Beachte, dass "
"dieser Hinweis auch öffentlich im Internet, zusammen mit den Koordinaten "
"deines Knotens, einsehbar sein wird."

….conf

rubo77 · 2016-09-01T16:42:36Z

Ich würde hier auch gerne Chat-Nickname ergänzen:

"e.g. E-mail, chat-nickname or phone number"

Aber dies besser in einem extra PR oder?

….conf (freifunk-gluon#843)

rotanid reviewed Aug 4, 2016
View reviewed changes

rubo77 force-pushed the package-contact-obligatory branch from 570c2e8 to 5d8712f Compare August 5, 2016 22:50

kb-light reviewed Aug 7, 2016
View reviewed changes

rubo77 force-pushed the package-contact-obligatory branch 3 times, most recently from 6113920 to cfb4196 Compare August 7, 2016 14:09

rubo77 mentioned this pull request Aug 7, 2016

The correct question to opt-in for an node-offline-email-alert #851

Closed

1 task

rotanid reviewed Aug 8, 2016
View reviewed changes

rubo77 force-pushed the package-contact-obligatory branch from cfb4196 to edd116f Compare August 8, 2016 15:18

rotanid added the 0. type: enhancement The changeset is an enhancement label Aug 22, 2016

neocturne reviewed Aug 28, 2016
View reviewed changes

neocturne modified the milestones: network-rewrite, 2016.2 Aug 28, 2016

rubo77 force-pushed the package-contact-obligatory branch 2 times, most recently from dab2b6a to 5578de9 Compare August 30, 2016 12:15

rubo77 force-pushed the package-contact-obligatory branch from 5578de9 to 0a93ad1 Compare September 1, 2016 11:40

neocturne reviewed Sep 1, 2016
View reviewed changes

rubo77 force-pushed the package-contact-obligatory branch 3 times, most recently from 0688d57 to d3c03b7 Compare September 1, 2016 16:32

gluon-config-mode-contact-info: define an "obligatory" option in site…

4172125

….conf

rubo77 force-pushed the package-contact-obligatory branch from d3c03b7 to 4172125 Compare September 1, 2016 16:35

neocturne merged commit d03c88a into freifunk-gluon:master Sep 7, 2016

rubo77 deleted the package-contact-obligatory branch September 7, 2016 07:55

rubo77 mentioned this pull request Nov 24, 2016

gluon-config-mode-contact-info: better message if contact field is empty #909

Closed

ecsv pushed a commit to FreifunkVogtland/gluon that referenced this pull request Jun 9, 2017

gluon-config-mode-contact-info: define an "obligatory" option in site…

d61d569

….conf (freifunk-gluon#843)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gluon-config-mode-contact-info: an "obligatory" option in site.conf #843

gluon-config-mode-contact-info: an "obligatory" option in site.conf #843

rubo77 commented Aug 4, 2016 •

edited

kb-light commented Aug 4, 2016

rubo77 commented Aug 4, 2016 •

edited

rotanid commented Aug 4, 2016

rotanid commented Aug 4, 2016

rubo77 commented Aug 4, 2016 •

edited

rotanid Aug 4, 2016

jplitza commented Aug 5, 2016

rubo77 commented Aug 5, 2016

kb-light Aug 7, 2016

rubo77 Aug 7, 2016 •

edited

kb-light Aug 7, 2016

rubo77 Aug 7, 2016

rotanid Aug 8, 2016

rubo77 Aug 8, 2016

neocturne Aug 28, 2016

rubo77 commented Aug 30, 2016

neocturne commented Aug 30, 2016

rubo77 commented Sep 1, 2016

neocturne Sep 1, 2016

rubo77 commented Sep 1, 2016

rubo77 commented Sep 1, 2016

gluon-config-mode-contact-info: an "obligatory" option in site.conf #843

gluon-config-mode-contact-info: an "obligatory" option in site.conf #843

Conversation

rubo77 commented Aug 4, 2016 • edited

kb-light commented Aug 4, 2016

rubo77 commented Aug 4, 2016 • edited

rotanid commented Aug 4, 2016

rotanid commented Aug 4, 2016

rubo77 commented Aug 4, 2016 • edited

Choose a reason for hiding this comment

jplitza commented Aug 5, 2016

rubo77 commented Aug 5, 2016

Choose a reason for hiding this comment

rubo77 Aug 7, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rubo77 commented Aug 30, 2016

neocturne commented Aug 30, 2016

rubo77 commented Sep 1, 2016

Choose a reason for hiding this comment

rubo77 commented Sep 1, 2016

rubo77 commented Sep 1, 2016

rubo77 commented Aug 4, 2016 •

edited

rubo77 commented Aug 4, 2016 •

edited

rubo77 commented Aug 4, 2016 •

edited

rubo77 Aug 7, 2016 •

edited