Merge pull request #209 from freifunk-gluon/autoupdater-fix-version-c…

…ompare autoupdater: fix version compare bugs
freifunk-gluon · Dec 20, 2018 · a52d5ce · a52d5ce
2 parents 1dc8416 + 30be52e
commit a52d5ce
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/admin/autoupdater/src/version.c b/admin/autoupdater/src/version.c
@@ -34,8 +34,10 @@ static int char_order(char c) {
 		return 0;
 	else if (isalpha(c))
 		return c;
-	else if (c == '~')
+	else if (c == '\0')
 		return -1;
+	else if (c == '~')
+		return -2;
 	else
 		return c + 256;
 }
@@ -47,7 +49,7 @@ bool newer_than(const char *a, const char *b) {
 	if (b == NULL)
 		return true;
 
-	while (*a != '\0' && *b != '\0') {
+	while (*a != '\0' || *b != '\0') {
 		int first_diff = 0;
 
 		// compare non-digits character by character