Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Extra style for nodes with uplink #30

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

maurerle
Copy link
Member

Description

This PR adds the option to style nodes with an uplink differently than meshing nodes.

Motivation and Context

This makes ist much easier to see, which node in the cloud has the uplink connection.

How Has This Been Tested?

Screenshots/links (if appropriate):

Checklist:

  • My code follows the code style of this project. (CI will test it anyway and also needs approval)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MyIgel
Copy link
Member

MyIgel commented Aug 31, 2023

That functionality is pretty great but imho it would be much more useful to not extend the circle but to inline it so to not change the overall size which makes the in the current state too crowded (especially when zoomed out).

@maurerle
Copy link
Member Author

maurerle commented Sep 3, 2023

I decreased the radius, which makes the circle about the same size.
I don't quite know what is the best approach for something like this..?

@MyIgel
Copy link
Member

MyIgel commented Sep 3, 2023

Decreasing it should be fine so that its effectively more an "inlay" than a border around the circle

@weeman1337 weeman1337 merged commit 6086ac0 into freifunk:main Sep 5, 2023
1 check passed
@maurerle maurerle deleted the uplink_style branch October 1, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants