Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

posts: EOL 8/64 devices #364

Merged
merged 1 commit into from
Dec 8, 2023
Merged

posts: EOL 8/64 devices #364

merged 1 commit into from
Dec 8, 2023

Conversation

grische
Copy link
Contributor

@grische grische commented Dec 7, 2023

No description provided.

d-e-f-i-d-o-c
d-e-f-i-d-o-c suggested changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@d-e-f-i-d-o-c d-e-f-i-d-o-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Als Newbie habe ich noch keine Ahnung, wie ich das hier machen sollte. Deswegen zunächst ein PDF mit den Änderungsvorschlägen:
EOL 8-64 devices.pdf

@T0biii
Copy link
Member

T0biii commented Dec 8, 2023

Hey @d-e-f-i-d-o-c
vielleicht helfen dir die beiden Docs Artikel weiter:
https://docs.github.com/de/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews
https://docs.github.com/de/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

Wie du über die GitHub Seite Änderungen vorschlagen kannst.

@grische grische force-pushed the eol-8-64 branch 2 times, most recently from 863883b to e908483 Compare December 8, 2023 13:39
@grische grische marked this pull request as ready for review December 8, 2023 13:39
@grische grische requested a review from a team as a code owner December 8, 2023 13:39
T0biii
T0biii approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@T0biii T0biii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awlx awlx merged commit 6e03dc0 into freifunkMUC:main Dec 8, 2023
1 check passed
@grische grische deleted the eol-8-64 branch December 9, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T0biii T0biii T0biii approved these changes

@d-e-f-i-d-o-c d-e-f-i-d-o-c d-e-f-i-d-o-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grische @T0biii @d-e-f-i-d-o-c @awlx