You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was looking at the differences between the current code and the code I am using and saw that one of the changes was the quoting of $FIND_L in the bin/freight-cache script.
Since FIND_L is set to either the empty string or the string -L, it should not be quoted in the call to find. If it is quoted (like now) and the value is the empty string (i.e. if $SYMLINKS is not on) you will get an error message from find (plus, admittedly, the desired output).
I saw this was changed in order to make shellcheck happy. I have no idea how it should be made happy, but this isn't it.
The text was updated successfully, but these errors were encountered:
The proper way to is to defined an Bash array to handle argument as described in shellcheck documentation though. If you use Bash array and it is empty, then Bash will not pass anything as argument.
I was looking at the differences between the current code and the code I am using and saw that one of the changes was the quoting of
$FIND_L
in thebin/freight-cache
script.Since
FIND_L
is set to either the empty string or the string-L
, it should not be quoted in the call tofind
. If it is quoted (like now) and the value is the empty string (i.e. if$SYMLINKS
is noton
) you will get an error message fromfind
(plus, admittedly, the desired output).I saw this was changed in order to make
shellcheck
happy. I have no idea how it should be made happy, but this isn't it.The text was updated successfully, but these errors were encountered: