Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of repository with sub-modules silently remove submodule if no commit found #200

Open
stchar opened this issue Feb 10, 2020 · 1 comment
Labels
contribution-required Maintainer has no time and/or no plans to work on this, interested parties should submit a patch

Comments

@stchar
Copy link

stchar commented Feb 10, 2020

Description:
I had had migrated a Mercurial repository with submodules to git. Then team pushed new changes to the Mercurial so I had to re-import it to git. Unfortunately I did a mistake: I forgot to re-import changes in submodule repository and just re-imported the parent repo. After a verification of git commits I found out that submodule was deleted.

Steps to reproduce

  1. create submodule mapping
    "submodule"="../submodule"

  2. Import submodule

  3. Import parent repository

  4. Add new commit in submodule mercurial repository

  5. Add new commit in parent mercurial repository

  6. Run hg-fast-import for parent repository only

Result:
Parent repository contains a commit with removal of sub-module.
Stdout contains a warning that commit of sub-module is missing

Expected result:
hg-fast-import.sh should throw error. Migration should be halted.

@frej
Copy link
Owner

frej commented Feb 13, 2020

That sounds like a bug, the reasonable thing is, as you say, to error out. @MokhamedDakhraui, @johannesc can you take a look?

@frej frej added the contribution-required Maintainer has no time and/or no plans to work on this, interested parties should submit a patch label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution-required Maintainer has no time and/or no plans to work on this, interested parties should submit a patch
Projects
None yet
Development

No branches or pull requests

2 participants