Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for callback refs? #62

Closed
mindplay-dk opened this issue Oct 10, 2019 · 5 comments
Closed

Add support for callback refs? #62

mindplay-dk opened this issue Oct 10, 2019 · 5 comments

Comments

@mindplay-dk
Copy link
Contributor

What do you think about adding support for callback refs?
@yisar
Copy link
Collaborator

yisar commented Oct 10, 2019

It shouldn't be difficult. I'll support it right away.

yisar added a commit that referenced this issue Oct 10, 2019
@yisar
supported ref callback #62
cb659cc
@yisar
Copy link
Collaborator

yisar commented Oct 10, 2019

Now it's supported 😀

@mindplay-dk
Copy link
Contributor Author

Let's leave this issue open for now, as a reminder to add a test.

@yisar
Copy link
Collaborator

yisar commented Oct 10, 2019 •
edited

Let's leave this issue open for now, as a reminder to add a test.

👌

@yisar yisar mentioned this issue Oct 27, 2019
Merged
@yisar yisar mentioned this issue Dec 11, 2019
Closed
@yisar
Copy link
Collaborator

yisar commented Dec 24, 2019

We already have tests about refs here, I'll close it first.

@yisar yisar closed this as completed Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mindplay-dk @yisar