Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dbpedia spotlight to NIF 2.1 #31

Open
jnehring opened this issue Aug 25, 2016 · 19 comments
Open

Update dbpedia spotlight to NIF 2.1 #31

jnehring opened this issue Aug 25, 2016 · 19 comments
Assignees

Comments

@jnehring
Copy link
Member

FREME does not generate any NIF when using DBPedia spotlight. The conversion from plaintext to NIF is done at DBPedia spotlight. Also the annotations are generated by DBPedia spotlight. So it is hard for us to update the output of dbpedia spotlight to NIF 2.1.

@m1ci what are the plans regarding dbpedia spotlight and nif 2.1? is an update planned?

@m1ci
Copy link
Contributor

m1ci commented Aug 25, 2016

on FREME side we can update the return from dbpedia spotlight so that it is NIF 2.1 ready.

@sandroacoelho sandroacoelho self-assigned this Aug 31, 2016
@sandroacoelho
Copy link
Contributor

Hi @m1ci , @jnehring

I will upgrade our NIF wraper to 2.1 for DBpedia Spotlight.

@jnehring
Copy link
Member Author

jnehring commented Oct 20, 2016

When this is finished we need to update the API documentation. freme-project/freme-project.github.io#294 added the parameter to all e-Services except dbpedia spotlight.

sandroacoelho added a commit that referenced this issue Jan 17, 2017
@sandroacoelho
Copy link
Contributor

Hi @m1ci , @jnehring

Spotlight has been updated to generate NIF 2.1. We don't need to use proxies anymore

Best,

@jnehring
Copy link
Member Author

Thank you I will test. The latest version is not installed on freme-dev because of freme-project/basic-services#119 . I will fix it and test afterwards.

@jnehring jnehring self-assigned this Jan 17, 2017
@jnehring
Copy link
Member Author

curl -X POST -H "Cache-Control: no-cache" -H "Postman-Token: c858ca9c-e4c8-fd55-9270-520160da243a" -d '' "http://rv1443.1blu.de/current/e-entity/dbpedia-spotlight/documents?confidence=0.3&input=This%2Bis%2BGermany&informat=text&language=en"

replies

{
  "exception": "eu.freme.common.exception.ExternalServiceFailedException",
  "path": "/e-entity/dbpedia-spotlight/documents",
  "error": "Bad Gateway",
  "status": 502,
  "timestamp": 1484645337262
}

Probably dbpedia spotlight is down right now,.

@m1ci
Copy link
Contributor

m1ci commented Jan 17, 2017

DBpedia spotlight now is using another endpoint and @sandroacoelho appropriately updated it in the FREME code. I guess the FREME instance running at http://rv1443.1blu.de/ is not using the latest code...maybe.

jnehring added a commit to freme-project/freme-parent that referenced this issue Jan 17, 2017
@jnehring
Copy link
Member Author

Right it did not use the latest code. I updated it and now the API request produces NIF 2.1.

One question: @sandroacoelho did you implement a nif-version parameter? Or does DBPedia spotlight produce nif 2.1 always?

@sandroacoelho
Copy link
Contributor

sandroacoelho commented Jan 17, 2017

DBpedia Spotlight always produces NIF 2.1, but we can add this parameter there if is useful

@jnehring
Copy link
Member Author

Ok. I think we do not need to add the parameter. Also when there is no parameter we do not need to update the documentation. So this topic is done. Many thanks for the implementation :)

@m1ci
Copy link
Contributor

m1ci commented Jan 18, 2017

@sandroacoelho it seems only english is enabled for dbpedia spotlight in FREME. Can you please enable all other possible languages that are available from this dbpedia spotlight intance?

@m1ci
Copy link
Contributor

m1ci commented Jan 18, 2017

@sandroacoelho please also update the documentation page

@jnehring how can we also have this updates fixed in the live instance?

@jnehring jnehring reopened this Jan 18, 2017
jnehring added a commit to freme-project/freme-project.github.io that referenced this issue Jan 18, 2017
@jnehring
Copy link
Member Author

documentation is updated. Now there is a problem in the live instance:

http://api.freme-project.eu/current/e-entity/dbpedia-spotlight/documents?confidence=0.3&input=This+is+Germany&informat=text&language=es&outformat=turtle

produces

{
  "exception": "eu.freme.common.exception.BadRequestException",
  "path": "/e-entity/dbpedia-spotlight/documents",
  "message": "java.nio.charset.MalformedInputException: Input length = 1",
  "error": "Bad Request",
  "status": 400,
  "timestamp": 1485268432877
}

But it seems this was fixed on dev. @sandroacoelho did you change the codes of dbpedia spotlight after the FREME 1.0 release?

http://rv1443.1blu.de/current/e-entity/dbpedia-spotlight/documents?confidence=0.3&input=This+is+Germany&informat=text&language=es&outformat=turtle

@m1ci
Copy link
Contributor

m1ci commented Jan 24, 2017

last change to the dbpedia spotlight code has been done on Jan 18, 2017 which seems to be a day before the release. Maybe the pom version has not been updated and thus the code changes not considered in the release?

See https://github.com/freme-project/e-services/commits/master

@jnehring
Copy link
Member Author

jnehring commented Jan 24, 2017

I dont think so because dbpedia spotlight was released to version 1.0 which is installed on the live server. Also on dev the 1.0 version is installed still. This is odd... but we need to get the dbpedia spotlight service fixed before the review.

@jnehring
Copy link
Member Author

jnehring commented Jan 25, 2017

I am not sure what is the difference between your and my API request.

This example has exactly the same parameters, only the input text differs. It works for "Diego Maradonna is form Argentina" and it does not work for "This is Germany":

http://api.freme-project.eu/current/e-entity/dbpedia-spotlight/documents?confidence=0.3&input=This+is+Germany&informat=text&language=es&outformat=turtle&dataset=dbpedia&mode=all

http://api.freme-project.eu/current/e-entity/dbpedia-spotlight/documents?confidence=0.3&input=Diego%20Maradona%20is%20from%20Argentina&informat=text&language=es&outformat=turtle&dataset=dbpedia&mode=all

@m1ci
Copy link
Contributor

m1ci commented Jan 25, 2017

Also if you switch the language parameter from en to es, then it works. @sandroacoelho, can you investigate?

@sandroacoelho
Copy link
Contributor

Hi @jnehring , @m1ci,

The problem is with our Spanish DBpedia Spotlight instance. I am checking the server right now.

@jnehring jnehring removed their assignment Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants