This repository has been archived by the owner on Oct 26, 2018. It is now read-only.
Tail recursion #11
Merged
Tail recursion #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test could use some improvement. The major place that it can be improved is in checking to see if the arity of the recursive call is the same as the arity of the function being defined.
|
Nice work :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another example for the analyzer: this finds things that look like tail recursion and warns that they should be replaced by recur. (Nothing in the standard library needs this.)
There are two areas where this could be improved: first, it would be nice to track the arity of the part of the function being analyzed, so that spurious warnings from multi-arity functions would not happen. Second, it would be nice to check the entire function for fns inside that are tail-recursive without calling recur.