Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump isort from 5.4.2 to 5.5.0 #168

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 4, 2020

Bumps isort from 5.4.2 to 5.5.0.

Release notes

Sourced from isort's releases.

5.5.0 September 3, 2020

  • Fixed #1398: isort: off comment doesn't work, if it's the top comment in the file.
  • Fixed #1395: reverse_relative setting doesn't have any effect when combined with force_sort_within_sections.
  • Fixed #1399: --skip can error in the case of projects that contain recursive symlinks.
  • Fixed #1389: ensure_newline_before_comments doesn't work if comment is at top of section and sections don't have lines between them.
  • Fixed #1396: comments in imports with ";" can keep isort from recognizing import line.
  • Fixed #1380: As imports removed when combine_star is set.
  • Fixed #1382: --float-to-top has no effect if no import is already at the top.
  • Fixed #1420: isort never settles on module docstring + add import.
  • Fixed #1421: Error raised when repo contains circular symlinks.
  • Fixed #1427: noqa comment is moved from star import to constant import.
  • Fixed #1444 & 1445: Incorrect placement of import additions.
  • Fixed #1447: isort5 throws error when stdin used on Windows with deprecated args.
  • Implemented #1397: Added support for specifying config file when using git hook (thanks @diseraluca!).
  • Implemented #1405: Added support for coloring diff output.
  • Implemented #1434: New multi-line grid mode without parentheses.

Goal Zero (Tickets related to aspirational goal of achieving 0 regressions for remaining 5.0.0 lifespan):

  • Implemented #1392: Extensive profile testing.
  • Implemented #1393: Proprety based testing applied to code snippets.
  • Implemented #1391: Create automated integration test that includes full code base of largest OpenSource isort users.

Potentially breaking changes:

  • Fixed #1429: --check doesn't print to stderr as the documentation says. This means if you were looking for ERROR: messages for files that contain incorrect imports within stdout you will now need to look in stderr.
Changelog

Sourced from isort's changelog.

5.5.0 September 3, 2020

  • Fixed #1398: isort: off comment doesn't work, if it's the top comment in the file.
  • Fixed #1395: reverse_relative setting doesn't have any effect when combined with force_sort_within_sections.
  • Fixed #1399: --skip can error in the case of projects that contain recursive symlinks.
  • Fixed #1389: ensure_newline_before_comments doesn't work if comment is at top of section and sections don't have lines between them.
  • Fixed #1396: comments in imports with ";" can keep isort from recognizing import line.
  • Fixed #1380: As imports removed when combine_star is set.
  • Fixed #1382: --float-to-top has no effect if no import is already at the top.
  • Fixed #1420: isort never settles on module docstring + add import.
  • Fixed #1421: Error raised when repo contains circular symlinks.
  • Fixed #1427: noqa comment is moved from star import to constant import.
  • Fixed #1444 & 1445: Incorrect placement of import additions.
  • Fixed #1447: isort5 throws error when stdin used on Windows with deprecated args.
  • Implemented #1397: Added support for specifying config file when using git hook (thanks @diseraluca!).
  • Implemented #1405: Added support for coloring diff output.
  • Implemented #1434: New multi-line grid mode without parentheses.

Goal Zero (Tickets related to aspirational goal of achieving 0 regressions for remaining 5.0.0 lifespan):

  • Implemented #1392: Extensive profile testing.
  • Implemented #1393: Proprety based testing applied to code snippets.
  • Implemented #1391: Create automated integration test that includes full code base of largest OpenSource isort users.

Potentially breaking changes:

  • Fixed #1429: --check doesn't print to stderr as the documentation says. This means if you were looking for ERROR: messages for files that contain incorrect imports within stdout you will now need to look in stderr.
Commits
  • f8888b3 Bump version to 5.5.0
  • e5deaf5 Merge pull request #1452 from PyCQA/issue/1382/broken-float-to-top
  • 2c84fc2 Formatting with black + isort
  • e2b2f8d Resolve #1382: float to top
  • 31f26da Add test for desired float_to_top behavior
  • a935c17 Fix docker file, add test suite
  • 6a34b64 Merge pull request #1451 from PyCQA/issue/1445/1444/add-import-placement-errors
  • b94f4d2 Resolve #1444 and Resolve #1445: Improve behavior of initial placement of imp...
  • 7fcfb9f Add test cases for both #1444 and 1445
  • c8cb55f Fix comment attaching, caught by missed coverage
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [isort](https://github.com/pycqa/isort) from 5.4.2 to 5.5.0.
- [Release notes](https://github.com/pycqa/isort/releases)
- [Changelog](https://github.com/PyCQA/isort/blob/develop/CHANGELOG.md)
- [Commits](PyCQA/isort@5.4.2...5.5.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Upgrade or downgrade of project dependencies. python labels Sep 4, 2020
@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files           8        8           
  Lines         224      224           
=======================================
  Hits          222      222           
  Misses          2        2           
Flag Coverage Δ
#unittests 99.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8431154...1adc58b. Read the comment docs.

@frenck frenck merged commit 8279431 into master Sep 4, 2020
@frenck frenck deleted the dependabot/pip/isort-5.5.0 branch September 4, 2020 06:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant