Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AdGuard Home package #252

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Refactor AdGuard Home package #252

merged 1 commit into from
Mar 10, 2021

Conversation

frenck
Copy link
Owner

@frenck frenck commented Mar 9, 2021

Major refactoring of the package.

  • Switched to use Poetry
  • Replaced GitHub Actions workflow:
    • More checks
    • More linting
    • More testing
    • More typechecking
    • Fully automated deployments
  • Tons of small improvements caused by the above.
  • Removal of old API/Bugs workarounds
  • Removes pure text response handling, as AdGuards API now handles it correctly well

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #252 (a69ffcb) into master (e62effc) will decrease coverage by 4.70%.
The diff coverage is 94.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   99.22%   94.52%   -4.71%     
==========================================
  Files          10        9       -1     
  Lines         259      292      +33     
  Branches        0       23      +23     
==========================================
+ Hits          257      276      +19     
- Misses          2        8       +6     
- Partials        0        8       +8     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/adguardhome/exceptions.py 100.00% <ø> (ø)
src/adguardhome/parental.py 90.47% <90.47%> (ø)
src/adguardhome/safebrowsing.py 90.47% <90.47%> (ø)
src/adguardhome/safesearch.py 90.47% <90.47%> (ø)
src/adguardhome/querylog.py 93.93% <93.93%> (ø)
src/adguardhome/stats.py 94.87% <94.87%> (ø)
src/adguardhome/filtering.py 96.77% <96.77%> (ø)
src/adguardhome/__init__.py 100.00% <100.00%> (ø)
src/adguardhome/adguardhome.py 95.60% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e62effc...a69ffcb. Read the comment docs.

@ghost
Copy link

ghost commented Mar 9, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

@frenck
Copy link
Owner Author

frenck commented Mar 10, 2021

Retry DeepCode

@frenck frenck merged commit 215b9f0 into master Mar 10, 2021
@frenck frenck deleted the frenck-2021-0854 branch March 10, 2021 17:09
@frenck frenck added the refactor Improvement of existing code, not introducing new features. label Mar 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Improvement of existing code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant