Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deepsource findings #257

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Address deepsource findings #257

merged 2 commits into from
Mar 11, 2021

Conversation

frenck
Copy link
Owner

@frenck frenck commented Mar 11, 2021

Proposed Changes

Addresses a couple of deepsource comments.

@frenck frenck added the refactor Improvement of existing code, not introducing new features. label Mar 11, 2021
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #257 (444e4da) into main (e3adba7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #257   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          280       280           
  Branches        17        17           
=========================================
  Hits           280       280           
Impacted Files Coverage Δ
src/adguardhome/adguardhome.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3adba7...444e4da. Read the comment docs.

@frenck frenck merged commit 40a0f05 into main Mar 11, 2021
@frenck frenck deleted the frenck-2021-0857 branch March 11, 2021 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Improvement of existing code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant