Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for allowlist in filters #259

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Add support for allowlist in filters #259

merged 1 commit into from
Mar 11, 2021

Conversation

frenck
Copy link
Owner

@frenck frenck commented Mar 11, 2021

Proposed Changes

This PR adds support for managing allowlists filters in AdGuard Home.

Additional, this is a bugfix; as currently the filter API calls will fail without the whitelist parameter.

Downstream issue: home-assistant/core#45296

@frenck frenck added new-feature New features or options. bugfix Inconsistencies or issues which will cause a problem for users or implementers. labels Mar 11, 2021
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #259 (0f01355) into main (03055dd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #259   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          280       283    +3     
  Branches        17        18    +1     
=========================================
+ Hits           280       283    +3     
Impacted Files Coverage Δ
src/adguardhome/filtering.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03055dd...0f01355. Read the comment docs.

@frenck frenck merged commit 0cd77f4 into main Mar 11, 2021
@frenck frenck deleted the frenck-2021-0859 branch March 11, 2021 19:11
@ghost
Copy link

ghost commented Mar 11, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers. new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant