Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of enabling/disabling specific filters #260

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Conversation

frenck
Copy link
Owner

@frenck frenck commented Mar 11, 2021

Proposed Changes

With the recent changes made to the API of AdGuard Home, they made some weird changes that require the name of the specific filters to enable/disable a filter.

The API is clearly created with simply their own UI in mind, because from an actual API perspective, this doesn't make sense.

Anyways, this works around it.

Downstream issue: home-assistant/core#45296

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Mar 11, 2021
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #260 (5776b36) into main (0cd77f4) will decrease coverage by 0.69%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##              main     #260      +/-   ##
===========================================
- Coverage   100.00%   99.30%   -0.70%     
===========================================
  Files            9        9              
  Lines          283      289       +6     
  Branches        18       20       +2     
===========================================
+ Hits           283      287       +4     
- Partials         0        2       +2     
Impacted Files Coverage Δ
src/adguardhome/filtering.py 97.10% <66.66%> (-2.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd77f4...5776b36. Read the comment docs.

@frenck frenck merged commit 85e8571 into main Mar 11, 2021
@frenck frenck deleted the frenck-2021-0860 branch March 11, 2021 20:24
@ghost
Copy link

ghost commented Mar 11, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant