Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flake8-comprehensions from 3.3.1 to 3.4.0 #266

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 19, 2021

Bumps flake8-comprehensions from 3.3.1 to 3.4.0.

Changelog

Sourced from flake8-comprehensions's changelog.

3.4.0 (2021-03-18)

  • Remove rules C407 (Unnecessary <dict/list> comprehension - <builtin> can take a generator) and C412 (Unnecessary <dict/list/set> comprehension

    • 'in' can take a generator). Both rules recommended increasing laziness, which is not always desirable and can lead to subtle bugs. Also, a fully exhausted generator is slower than an equivalent comprehension, so the advice did not always improve performance.

    Thanks to David Smith, Dylan Young, and Leonidas Loucas for the report in Issue [#247](https://github.com/adamchainz/flake8-comprehensions/issues/247) <https://github.com/adamchainz/flake8-comprehensions/issues/247>__.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Upgrade or downgrade of project dependencies. python labels Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #266 (eea7094) into main (62f0f23) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #266   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          287       287           
  Branches        18        18           
=========================================
  Hits           287       287           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62f0f23...eea7094. Read the comment docs.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 19, 2021

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot dependabot bot force-pushed the dependabot/pip/flake8-comprehensions-3.4.0 branch from 42008b3 to b4f8ac6 Compare March 19, 2021 08:59
@dependabot dependabot bot force-pushed the dependabot/pip/flake8-comprehensions-3.4.0 branch from b4f8ac6 to eea7094 Compare March 19, 2021 09:22
@frenck frenck merged commit 58ff14b into main Mar 19, 2021
@frenck frenck deleted the dependabot/pip/flake8-comprehensions-3.4.0 branch March 19, 2021 09:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant