Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hint for client constructor arguments #297

Merged
merged 1 commit into from
May 1, 2021
Merged

Conversation

frenck
Copy link
Owner

@frenck frenck commented May 1, 2021

Proposed Changes

Type hint and their allowed values didn't match in the constructor signature. This PR fixes that.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label May 1, 2021
@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #297 (9a02b0f) into main (b7ec5e1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #297   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          287       287           
  Branches        18        18           
=========================================
  Hits           287       287           
Impacted Files Coverage Δ
src/adguardhome/adguardhome.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ec5e1...9a02b0f. Read the comment docs.

@frenck frenck merged commit 43385df into main May 1, 2021
@frenck frenck deleted the frenck-2021-1349 branch May 1, 2021 14:47
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant