Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async_timeout deprecation warning. #471

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Fix async_timeout deprecation warning. #471

merged 1 commit into from
Jan 31, 2022

Conversation

yuxincs
Copy link
Contributor

@yuxincs yuxincs commented Jan 29, 2022

Proposed Changes

A very simple fix for the deprecation warning from async_timeout when testing home assistant's adguard integration:

tests/components/adguard/test_config_flow.py: 32 warnings
 /homeassistant/lib/python3.9/site-packages/adguardhome/adguardhome.py:135: DeprecationWarning: with timeout() is deprecated, use async with timeout() instead
    with async_timeout.timeout(self.request_timeout):

Related Issues

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #471 (ff20470) into main (2014fe2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #471   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          287       287           
  Branches        27        27           
=========================================
  Hits           287       287           
Impacted Files Coverage Δ
src/adguardhome/adguardhome.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2014fe2...ff20470. Read the comment docs.

Copy link
Owner

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yxwangcs 👍

@frenck frenck merged commit 37c3432 into frenck:main Jan 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants