Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Content-Type header #677

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Skip Content-Type header #677

merged 2 commits into from
Jan 3, 2023

Conversation

zeehio
Copy link
Contributor

@zeehio zeehio commented Dec 29, 2022

Proposed Changes

Skip Content-Type header when there is no data in body.

I haven't test this and I probably won't have time until February to test this.

Related Issues

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Jan 3, 2023
Copy link
Owner

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and works as expected.

Result without this change: Media error (415)
Result with this change: No errors, command go through

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #677 (e6e3eef) into main (a6572e1) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e6e3eef differs from pull request most recent head 82c4eb6. Consider uploading reports for the commit 82c4eb6 to get more accurate results

@@            Coverage Diff            @@
##              main      #677   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          287       290    +3     
  Branches        18        19    +1     
=========================================
+ Hits           287       290    +3     
Impacted Files Coverage Δ
src/adguardhome/adguardhome.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@frenck frenck merged commit 84f75d5 into frenck:main Jan 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants