馃殤 Fixes calculation for average processing time #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AdGuard Home API returns the value in seconds. To correctly convert that value into milliseconds, the multiplication should be 1000.
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 8 8
Lines 224 224
=======================================
Hits 222 222
Misses 2 2
Continue to review full report at Codecov.
|
frenck
approved these changes
Apr 3, 2020
frenck
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AdGuard Home API returns the value in seconds. To correctly convert that value into milliseconds, the multiplication should be 1000.
API result
{"avg_processing_time": "0.008353"}I noticed this in Home Assistant. The AdGuard Home page showed my average processing time as 8ms, while the Home Assistant sensor (incorrectly) had 0.8ms for this value.
AdGuard Home
Home Assistant sensor
