Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax Wi-Fi rssi & encryption parameters #226

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Relax Wi-Fi rssi & encryption parameters #226

merged 1 commit into from
Sep 17, 2022

Conversation

frenck
Copy link
Owner

@frenck frenck commented Sep 17, 2022

Proposed Changes

Relaxes the rssi and encryption reported values. Multiple reports came in, where those two have been missing (or None).

They are not critical, so relaxing their validation in this PR.

fixes #223
Ref:

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Sep 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2022

Codecov Report

Merging #226 (1837a4b) into main (35e5bf1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files           6        6           
  Lines         354      354           
  Branches       52       52           
=======================================
  Hits          340      340           
  Misses         12       12           
  Partials        2        2           
Impacted Files Coverage Δ
src/demetriek/models.py 93.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@frenck frenck merged commit 9292806 into main Sep 17, 2022
@frenck frenck deleted the frenck-2022-1832 branch September 17, 2022 13:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strictness of Wifi model doesn't match in-the-field device payload
2 participants