Add tags field in Device model #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tailscale's API exposes the ACL tags of devices. This commit prevents the tags from being discarded.
Fixes an issue where the validation of a Device would fail if the tags list is not present (reproducible if the "hello" external tailscale service is joined to your tailnet)
I forgot that the Optional type can contain a typed type inside it. The field is now actually optional.
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 91.66% 91.74% +0.07%
==========================================
Files 4 4
Lines 108 109 +1
Branches 15 15
==========================================
+ Hits 99 100 +1
Misses 8 8
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
frenck
approved these changes
Aug 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR updates the Device model to expose the ACL tags. The field is not listed in the official API documentation (or wasn't when I looked yesterday) but it is returned by the API, and is a useful field to have.
Related Issues
None - just directly fixing when I noticed the issue