Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pydantic v2 support #442

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Revert pydantic v2 support #442

merged 1 commit into from
Nov 4, 2023

Conversation

frenck
Copy link
Owner

@frenck frenck commented Nov 4, 2023

Proposed Changes

SSIA, reverts Pydantic v2 support.

The stub in v2, doesn't do it. Reverting it for now, removing it fully soon by replacing it with e.g., msgpack or mashumaro.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Nov 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

Merging #442 (a29350a) into main (e36efdc) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
- Coverage   90.99%   90.90%   -0.09%     
==========================================
  Files           4        4              
  Lines         111      110       -1     
  Branches       15       15              
==========================================
- Hits          101      100       -1     
  Misses          9        9              
  Partials        1        1              
Files Coverage Δ
src/tailscale/models.py 91.83% <100.00%> (-0.17%) ⬇️

Copy link

sonarcloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@frenck frenck merged commit 55546a2 into main Nov 4, 2023
23 checks passed
@frenck frenck deleted the frenck-2023-1375 branch November 4, 2023 21:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants