Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pydantic with mashumaro #443

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Replace pydantic with mashumaro #443

merged 3 commits into from
Nov 4, 2023

Conversation

frenck
Copy link
Owner

@frenck frenck commented Nov 4, 2023

Proposed Changes

SSIA

Say goodbye to pydantic.

@frenck frenck added the enhancement Enhancement of the code, not introducing new features. label Nov 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

Merging #443 (84d3359) into main (55546a2) will decrease coverage by 0.56%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
- Coverage   90.90%   90.35%   -0.56%     
==========================================
  Files           4        4              
  Lines         110      114       +4     
  Branches       15       15              
==========================================
+ Hits          100      103       +3     
- Misses          9       10       +1     
  Partials        1        1              
Files Coverage Δ
src/tailscale/tailscale.py 88.67% <50.00%> (-0.21%) ⬇️
src/tailscale/models.py 90.74% <88.09%> (-1.10%) ⬇️

Copy link

sonarcloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@frenck frenck marked this pull request as ready for review November 4, 2023 22:52
@frenck frenck merged commit 19a1a93 into main Nov 4, 2023
23 checks passed
@frenck frenck deleted the frenck-2023-1376 branch November 4, 2023 22:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants