Fix for event filter #666
Merged
Fix for event filter #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
added
the
bugfix
frenck
approved these changes
Mar 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes upcoming breaking change in 2024.4 as referenced in #665 and home-assistant/core#113798 (comment)
This change makes it backward compatible with previous releases by checking type of event param
Motivation and Context
Solves breaking change in 2024.4
Motivation - I had to fix this myself in Battery Notes so sharing as Spook has been great inspiration for me starting out creating custom components.
How has this been tested?
Tested against current releases prior to 2024.4 only
Screenshots (if appropriate):
Types of changes
Checklist
fixes #665