Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detecting empty device IDs #669

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Fix detecting empty device IDs #669

merged 1 commit into from
Mar 23, 2024

Conversation

frenck
Copy link
Owner

@frenck frenck commented Mar 23, 2024

Description

Fixes a regression from #606, which caused us no longer skip empty device IDs.

fixes #619

Motivation and Context

While empty device ID are, actually, not good. They are accepted by Home Assistant (and abused in Blueprints quite a bit). Therefore, skipping makes sense to prevent bunch of bug report 馃檮

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Mar 23, 2024
Copy link

sonarcloud bot commented Mar 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@frenck frenck merged commit 923d7f6 into main Mar 23, 2024
15 checks passed
@frenck frenck deleted the frenck-2024-0261 branch March 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty string for device triggers a repair (should be fixed)
1 participant