Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial fix for Async 111.13.00 #124

Merged
merged 1 commit into from
May 19, 2014
Merged

Trivial fix for Async 111.13.00 #124

merged 1 commit into from
May 19, 2014

Conversation

jnfoster
Copy link
Member

This epic one-character commit fixes #123

@seliopou not sure if we want to bump the version of Async required or not. However, 111.13.00 is what's in OPAM these days...

@basus
Copy link
Member

basus commented May 17, 2014

Thanks! I'm guessing we have to bump the version for the Travis CI build to pass?

@seliopou
Copy link
Collaborator

opam-street needs to be updated in order for the build to pass. There may be other incompatibilities as well, so let's hold off on merging this stuff until Monday when I'll dig into this and all the other outstanding pull requests.

@seliopou seliopou self-assigned this May 17, 2014
@jnfoster
Copy link
Member Author

I agree with Spiros.

And even without this one-character fix, there's absolutely no need to
block progress on your work because one can always install the older
working version via OPAM.

-N

On Sat, May 17, 2014 at 4:44 PM, Spiros Eliopoulos <notifications@github.com

wrote:

opam-street needs to be updated in order for the build to pass. There may
be other incompatibilities as well, so let's hold off on merging this stuff
until Monday when I'll dig into this and all the other outstanding pull
requests.


Reply to this email directly or view it on GitHubhttps://github.com//pull/124#issuecomment-43423627
.

seliopou added a commit that referenced this pull request May 19, 2014
@seliopou seliopou merged commit 7a69f09 into master May 19, 2014
@seliopou seliopou deleted the async_111.13.00_fix branch May 19, 2014 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build broken with asnyc 111.13?
3 participants