Envelope labels #173
Merged
Envelope labels #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
It seems to work well. I did a bit of manual testing. Here are a few findings:
- One tiny detail: the buttons seem to be too close to each other (this doesn't affect the functionality).
- Then the error message when entering a higher/lower number does not seem to be in Czech.
- With the Skipping first x number of labels maybe preparing the system for the situation when nothing is added (an empty field is sent). At the moment you get an error.
- With the labels sheet itself - is it planned to print out the whole page on the pre-cut labels? And does this layout fit the labels?
Comment on lines
+125
to
+130
| if not (0 <= self.skip.data < 16): | ||
| flash("Vynechat lze 0 až 15 štítků.", "danger") | ||
| return False |
There was a problem hiding this comment.
I tested this manually and the propper message does not seem to show itself. I see only an info message in English.
There was a problem hiding this comment.
It works if you have disabled javascript. If you use JS, the browser doesn't allow you to send the request to the server.
Those are messages produced by the browser, I believe. I will test it today on a system with Czech locales.
Good catch, will use 0 in that case.
Yes, exactly, I'll add a comment to the top od the HTML page. |
frenzymadness
force-pushed
the
envelope_labels
branch
from
e13fef2
to
c1036b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nová možnost tisknout štítky na obálky.