Skip to content

Commit

Permalink
Add todos
Browse files Browse the repository at this point in the history
  • Loading branch information
joswarmer committed Jun 20, 2024
1 parent 65acc6f commit e178e3a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/core/src/editor/boxes/Box.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export abstract class Box {
if (this.isLeaf() && this.selectable) {
return this;
}
// TODO Why filter or concat here?
const childrenReversed = this.children.filter(ch => true).reverse();
for (const child of childrenReversed) {
const leafChild = child.lastLeaf;
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/typer/FreTypeOrderedList.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export class FreTypeOrderedList<T extends FreType> implements Iterable<T> {
}

add(p: T, typer: FreTyper) {
// TODO Why use typeof
if (!!typer) {
if (!this.elements.find(e => typer.equals(e, p))) {
this.elements.push(p);
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/util/FreUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export class FreUtils {

static setContainer(exp: FreNode, freOwnerDescriptor: FreOwnerDescriptor | null, editor: FreEditor): void {
runInAction(() => {
// TODO Why use typeof
if (!!freOwnerDescriptor) {
if (freOwnerDescriptor.propertyIndex === undefined) {
freOwnerDescriptor.owner[freOwnerDescriptor.propertyName] = exp;
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/validator/FreValidator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export class FreError {
this.message = message;
this.reportedOn = node;
this.locationdescription = locationdescription;
// TODO Why use typeof
if (!!severity) {
this.severity = severity;
} else {
Expand Down

0 comments on commit e178e3a

Please sign in to comment.