Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add param for Dry run to use a DB file instead of memory #182

Merged
merged 1 commit into from Dec 14, 2017
Merged

Add param for Dry run to use a DB file instead of memory #182

merged 1 commit into from Dec 14, 2017

Conversation

glonlas
Copy link
Member

@glonlas glonlas commented Dec 14, 2017

Add a command line param --dry-run-db that will use tradesv3.dry_run.sqlite instead of memory.

  1. Works only if dry run is enabled.
  2. Is ignored if dry run is disabled.
  3. Create tradesv3.dry_run.sqlite if does not exist

Help message

 --dry-run-db          Force dry run to use a local DB
                        "tradesv3.dry_run.sqlite" instead of memory DB. Work
                        only if dry_run is enabled.

gcarq
gcarq approved these changes Dec 14, 2017
View reviewed changes
Copy link
Member

@gcarq gcarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcarq gcarq merged commit 2ac8b68 into freqtrade:develop Dec 14, 2017
jpipas added a commit to jpipas/freqtrade that referenced this pull request Dec 15, 2017
@jpipas
Merge remote-tracking branch 'upstream/develop' into develop
1301693 
* upstream/develop:
  Use ENTRYPOINT instead of CMD so additional arguments can be supplied for docker run. (freqtrade#184)
  Add param for Dry run to use a DB file instead of memory (freqtrade#182)
@glonlas glonlas deleted the param_dryrun_db branch December 16, 2017 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcarq gcarq gcarq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glonlas @gcarq