Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter fixes #2

Merged
merged 7 commits into from Aug 31, 2017
Merged

Linter fixes #2

merged 7 commits into from Aug 31, 2017

Conversation

vertti
Copy link
Member

@vertti vertti commented Aug 28, 2017

This PR fixes a bunch of fairly trivial warnings from PyLint linter. Easiest to review commit-by-commit.

@vertti
Copy link
Member Author

vertti commented Aug 30, 2017

Hello @gcarq . We like your bot and would love to help take it to the next level. We will be actively developing our fork and would like to send you the PR's, but the longer they are unmerged on your repo, the harder it gets to create and merge the PRs.

Please let us know if you are interested in getting more PR's to your bot or if we should just go on with our own fork.

@gcarq
Copy link
Member

gcarq commented Aug 31, 2017

Thanks a lot! I'm happy to merge future PR's, I will do my best to merge them in a timely manner. What are your plans to take it to the next level?

cheers,
Michael

@vertti
Copy link
Member Author

vertti commented Aug 31, 2017

Rough initial ideas:

  • asyncio for running more queries to bittrex in parallel or maybe with websocket when that is available
  • separate the buying and selling so they can be run in parallel too
  • more indicators aside from MACD & StochRSI, maybe volume/volatility etc.
  • way to benchmark/simulate changes to indicators, like taking historical data and see how the bids/sells would have performed
  • adding enough unit testing to bullet proof the basic functionality

@gcarq
Copy link
Member

gcarq commented Aug 31, 2017

Sounds very nice, I'm looking forward to it

@gcarq gcarq merged commit 43133f0 into freqtrade:master Aug 31, 2017
@seansan seansan mentioned this pull request Jan 5, 2018
@macd2 macd2 mentioned this pull request Feb 2, 2018
@ghost ghost mentioned this pull request Mar 20, 2018
This was referenced Jun 25, 2021
@samgermain samgermain mentioned this pull request Jul 31, 2021
@kamontat kamontat mentioned this pull request Aug 5, 2021
@mablue mablue mentioned this pull request Aug 16, 2021
@vatir vatir mentioned this pull request Aug 24, 2021
@arris69 arris69 mentioned this pull request Oct 24, 2021
xmatthias pushed a commit that referenced this pull request Nov 30, 2021
@omararturo omararturo mentioned this pull request Apr 9, 2022
@ghost ghost mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants