Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements to Hyperopt #235

Merged
merged 9 commits into from Dec 25, 2017
Merged

Conversation

vertti
Copy link
Member

@vertti vertti commented Dec 25, 2017

  • Consider eval with zero trades made a failure. This way I was able to remove all the nan filtering etc.
  • Log result string only when eval round is better than any before on this run, otherwise prints a dot.
  • Make log results go to a new line so they align and are easy to read.
  • Shorten and remove noise from logged lines from hyperopt.

After changes the logging normally looks like this:

.................
 5803/10000:    160 trades. Avg profit  0.45%. Total profit  0.00682250 BTC. Avg duration  43.6 mins.
.....................................................................................
 5889/10000:    178 trades. Avg profit  0.41%. Total profit  0.00682182 BTC. Avg duration  43.6 mins.
..................................

Copy link
Member

@gcarq gcarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a minor comment, LGTM otherwise

@@ -101,14 +98,14 @@

def log_results(results):
"if results is better than _TO_BEAT show it"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is outdated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed it.

@gcarq gcarq merged commit 9959d53 into develop Dec 25, 2017
@gcarq gcarq deleted the logging-improvement-hyperopt branch December 25, 2017 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants