Add more unit tests #241
Merged
Add more unit tests #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glonlas
force-pushed
the
add_unittests
branch
from
7f3bee7
to
c1a7fb4
Compare
vertti
reviewed
Dec 27, 2017
freqtrade/tests/test_main.py
Outdated
| validate_pairs=MagicMock(), | ||
| get_ticker=ticker, | ||
| buy=MagicMock(return_value='mocked_limit_buy')) | ||
| mocker.patch('freqtrade.main.min_roi_reached', MagicMock(return_value=True)) |
There was a problem hiding this comment.
mocker.patch uses MagicMock by default so you can simplify that with just
mocker.patch('freqtrade.main.min_roi_reached', return_value=True)
There was a problem hiding this comment.
Thanks for the tips. I will do it.
glonlas
force-pushed
the
add_unittests
branch
from
c1a7fb4
to
7f69230
Compare
|
@vertti your comment is fixed. Waiting for the tests to pass. |
|
Looks good to me. |
gcarq
approved these changes
Dec 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for the fun, more unit tests more coverage \o/