Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder and revamp the documentation #279

Merged
merged 4 commits into from Jan 3, 2018
Merged

Conversation

glonlas
Copy link
Member

@glonlas glonlas commented Jan 2, 2018

This PR improve the documentation by trying to explain in details all steps to set up the bot.

Broken element in this branch

You will see on README.md the image link and link to documentation pages are broken. This is normal. If you look closely the URL links to /develop/ branch.

Missings parts

  • How to use hyperopt and how to read the results. It will be part of another PR
  • Template for sending an issue and a pull-request

@vertti
Copy link
Member

vertti commented Jan 2, 2018

Hyperopt using is described in our wiki. https://github.com/gcarq/freqtrade/wiki/Testing-new-strategies-with-Hyperopt

@glonlas
Copy link
Member Author

glonlas commented Jan 2, 2018

I have to integrate it into this PR. One goal of this PR is to allow users to improve the documentation and also be able to track modifications.

README.md Outdated
This software is for educational purposes only. Do not risk money which
you are afraid to lose. Always start by running a trading bot in Dry-run and do not engage money
before you understand how it works and what profit/loss you should
expect.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should use this opportunity to add a final note along the lines of USE THE SOFTWARE AT YOUR OWN RISK. THE AUTHORS AND ALL AFFILIATES ASSUME NO RESPONSIBILITY FOR YOUR TRADING RESULTS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like your additions here though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Added to the documentation.

@@ -0,0 +1,157 @@
# Bot Optimization
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be Github wiki pages that we link to from README.md.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with the wiki is that no-one can edit it if you are not an admin. And even for us we cannot review and roll it back.

I would like to give the chance from non-tech to contribute to the doc.

@shusso
Copy link
Member

shusso commented Jan 2, 2018

Good stuff @glonlas 👍

@vertti
Copy link
Member

vertti commented Jan 2, 2018

But damn, all in all that was one awesome set of new documentation, good work!

README.md Outdated
'should' be stable on this branch, and is generally well tested.

## Features
- [x] **Based on Python**: For botting on any operating system -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we require python3.6+ which should be mentioned somewhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a whole section about the software requirements in the README.md


**With live data (do not alter your testdata files)**
```bash
python3 ./freqtrade/main.py -c config.json backtesting --realistic-simulation --live
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to pass the -c here, shouldn't we use the config by default in backtestging/hyperopt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

cp config.json.example config.json
```
To edit the config please refer to the [Bot Configuration](https://github.com/gcarq/freqtrade/blob/develop/docs/configuration.md) page
5. Create your DB file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't these created automatically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

```

**2.3.2. Install Python 3.6**
- [Python 3.6 MacOS offical page](https://www.python.org/downloads/mac-osx/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC on osx you can just brew install python3 to get the latest released version of python

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that is the preferable method.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

source .env/bin/activate
pip3.6 install -r requirements.txt
pip3.6 install -e .
pip3.6 install hyperopt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, as hyperopt is in requirements.txt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@glonlas
Copy link
Member Author

glonlas commented Jan 3, 2018

Thank you very much for your review and comments. I am updating the PR, then we can merge it.

@glonlas glonlas merged commit 407eaa0 into develop Jan 3, 2018
@glonlas glonlas deleted the revamp_documentations branch January 3, 2018 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants