Convert CryptoToFiatConverter into a Singleton #423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Speed up unit test from 60s to 6s by Change
CryptoToFiatConverter()
to a Singleton.The issue is
CryptoToFiatConverter()
callPymarketcap()
lib at the__init__
. WhenPymarketcap()
get instanced, it calls some other services. It results in a latency of 2 sec.By changing
CryptoToFiatConverter()
to a Singleton, we avoid to initPymarketcap()
every time.Solve the issue: #420
Quick changelog
CryptoToFiatConverter()
to a Singleton. The bot will instancePymarketcap()
only once.CryptoToFiatConverter()
What's new?
Faster unit tests, Faster bot.
Below the new performance of the tests.