Feat/telegram sell msg #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vertti
approved these changes
Jan 22, 2018
freqtrade/main.py
Outdated
| *Amount:* `{amount}` | ||
| *Open Rate:* `{open_rate:.8f}` | ||
| *Current Rate:* `{current_rate:.8f}` | ||
| *Current Profit:* `{current_profit:.2f}%` |
There was a problem hiding this comment.
I'd say because you are selling it, we should say "Profit", not "Current profit".
| @@ -107,7 +107,7 @@ def test_status_handle(default_conf, update, ticker, mocker): | |||
| _status(bot=MagicMock(), update=update) | |||
|
|
|||
| assert msg_mock.call_count == 1 | |||
| assert '[BTC_ETH]' in msg_mock.call_args_list[0][0][0] | |||
| assert '[BTC/ETH]' in msg_mock.call_args_list[0][0][0] | |||
There was a problem hiding this comment.
The slash seems awkward, I haven't seen it used in currency pairs, it seems to always be BTC-ETH or BTC_ETH. Should we stick with that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add more information about the trade on Sell message to telegram. Also
/statusreports now the total amount of tradesSolve the issue: #410