Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperopt protections and Boolean parameter #5360

Merged
merged 9 commits into from
Aug 7, 2021
Merged

Conversation

xmatthias
Copy link
Member

@xmatthias xmatthias commented Aug 4, 2021

Summary

Add hyperopt support for protections

closes #4458

Quick changelog

  • Requires protections to be set as property in the strategy
  • config / regular attribute settings are still supported (But shouldbe considered deprecated).
  • Add BooleanParameter - a shorthand for CategoricalParameter([True, False]).

@xmatthias xmatthias added Enhancement Enhancements to the bot. Get lower priority than bugs by default. Hyperopt Hyperopt related issues and pull requests labels Aug 4, 2021
@coveralls
Copy link

coveralls commented Aug 4, 2021

Coverage Status

Coverage increased (+0.03%) to 98.178% when pulling ad0e4a8 on hyperopt_protections into 74a5cb3 on develop.

@xmatthias xmatthias changed the title Hyperopt protections Hyperopt protections and Boolean parameter Aug 4, 2021
Copy link

@Joy2489 Joy2489 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@xmatthias xmatthias merged commit 6532aba into develop Aug 7, 2021
@xmatthias xmatthias deleted the hyperopt_protections branch August 7, 2021 07:42
@Joy2489
Copy link

Joy2489 commented Aug 7, 2021 via email

@xmatthias
Copy link
Member Author

Done.

On Sat, 7 Aug, 2021, 1:12 pm Matthias, @.***> wrote: Merged #5360 <#5360> into develop. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5360 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVDBX2DGVU4BEM7FWQZCMPTT3TPVPANCNFSM5BRXFBVQ .

While i'm not against comments or reviews - this is unnecessary / spam which will cause unnecessary notification for everyone involved in the issues youre sending these things to.
As such - i'd ask you to please stop posting unnecessary comments (comments that add value are however always welcome).

@Joy2489

This comment has been minimized.

@NINEZEE90
Copy link

@xmatthias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhancements to the bot. Get lower priority than bugs by default. Hyperopt Hyperopt related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hyperopt for protections
4 participants