Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't blindly create coroutines, but fire them off in batches #5560

Merged
merged 4 commits into from Sep 11, 2021
Merged

Don't blindly create coroutines, but fire them off in batches #5560

merged 4 commits into from Sep 11, 2021

Conversation

xmatthias
Copy link
Member

@xmatthias xmatthias commented Sep 10, 2021 •
edited

Summary

Use batching to when sending requests for downloading data

closes #5548

Quick changelog

  • use batching
  • test this approach further

@coveralls
Copy link

coveralls commented Sep 10, 2021 •
edited

Coverage Status

Coverage increased (+0.0002%) to 98.301% when pulling a5f90a4 on fix/5548_1mdl into 7251a3a on develop.

@xmatthias xmatthias mentioned this pull request Sep 10, 2021
Closed
@xmatthias xmatthias added the Data download Issues related to fetching historical data label Sep 10, 2021
@xmatthias xmatthias merged commit 50479d0 into develop Sep 11, 2021
@xmatthias xmatthias deleted the fix/5548_1mdl branch September 11, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Data download Issues related to fetching historical data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

download-data 1m tickers produces empty files
2 participants
@xmatthias @coveralls