-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datetime helpers, reduce arrow usage to a minimum #8661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmatthias
added
the
Tech maintenance
Technical debt and maintenance - point out issues we should resolve long-term
label
May 19, 2023
xmatthias
force-pushed
the
feat/datetimehelpers
branch
from
May 19, 2023 05:15
cd078a7
to
9d0f488
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Tech maintenance
Technical debt and maintenance - point out issues we should resolve long-term
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reduce arrow usage to a minimum in favor of internal datetime helpers (we always need the date in exactly the same format).
It'll also help should we need to make further changes in this regards.
Usage of datetime is not reduced by this, but will be replaced by
dt_now()
over time.Arrow remains a dependency for now, but used only for humanization.
it's however not providing benefits to other areas - as
datetime.now(timezone.utc)
works perfectly fine to get a date (vs.arrow.utcnow().datetime
.Quick changelog