Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datetime helpers, reduce arrow usage to a minimum #8661

Merged
merged 29 commits into from
May 22, 2023

Conversation

xmatthias
Copy link
Member

Summary

Reduce arrow usage to a minimum in favor of internal datetime helpers (we always need the date in exactly the same format).
It'll also help should we need to make further changes in this regards.

Usage of datetime is not reduced by this, but will be replaced by dt_now() over time.

Arrow remains a dependency for now, but used only for humanization.
it's however not providing benefits to other areas - as datetime.now(timezone.utc) works perfectly fine to get a date (vs. arrow.utcnow().datetime.

Quick changelog

  • don't use arrow throughout the code

@xmatthias xmatthias added the Tech maintenance Technical debt and maintenance - point out issues we should resolve long-term label May 19, 2023
@coveralls
Copy link

coveralls commented May 19, 2023

Coverage Status

Coverage: 94.48% (-0.01%) from 94.493% when pulling 9d0f488 on feat/datetimehelpers into 707c674 on develop.

@xmatthias xmatthias merged commit 85c1457 into develop May 22, 2023
24 checks passed
@xmatthias xmatthias deleted the feat/datetimehelpers branch May 22, 2023 16:22
@xmatthias xmatthias mentioned this pull request Oct 13, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech maintenance Technical debt and maintenance - point out issues we should resolve long-term
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants