compute_interval must use total seconds #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compute_interval must use total seconds, otherwise it's wrong for every timeframe > 1 day
Discovered while analyzing freqtrade/freqtrade-strategies#62
which uses 4h timeframe and resamples to 2d - so
resampled_merge()
returns always resampled_0_sma instead of resampled_2880_sma.Documentation improvement
Also adds a proper example for resampling - since this continues to raise questions.