New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] mainnet wasm has wrong version #882

Closed

p5150j opened this issue Jan 6, 2023 · 0 comments · Fixed by #884

Assignees

Labels

bug

Collaborator

p5150j commented Jan 6, 2023

Frequency: Frequency release mainnet wasm has wrong version "frequency-rococo" that should be "frequency"

p5150j added the bug label

wilwade assigned shannonwells, rlaferla, demisx and saraswatpuneet

wilwade mentioned this issue

Bug Fix (#882) Use correct feature flags with srtool #884

Merged

1 task

wilwade closed this as completed in

6053ae1

abadaa pushed a commit that referenced this issue


          Bug Fix (#882) Use correct feature flags with srtool (#884)

45f21a3

# Goal
The goal of this PR is to make sure that the correct feature flags are
being used with srtool for wasm generation

Closes #882 

# Discussion
- srtool default-features flag does not work as intended
- Instead using build-opts
- Enabled debug logging in srtool for easier checking
- Added subwasm check to test the output wasm

Test Runs:
- Mainnet:
https://github.com/LibertyDSNP/frequency/actions/runs/3859784794/jobs/6579633360
<img width="1010" alt="image"
src="https://user-images.githubusercontent.com/1252199/211126355-d6f917d3-0ef2-447c-8f81-ac5333ce34d1.png">

- Rococo:
https://github.com/LibertyDSNP/frequency/actions/runs/3859784794/jobs/6579633325
<img width="892" alt="image"
src="https://user-images.githubusercontent.com/1252199/211126378-037467be-b34d-4e6c-bafb-effdafb46328.png">


# Checklist
- [x] Tests added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment