chore(upgrade): v1.4.0 to v1.5.0 #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
github-actions
bot
added
the
metadata-changed
enddynayn
requested review from
aramikm,
mattheworris,
claireolmstead,
shannonwells and
saraswatpuneet
github-actions
bot
added
metadata-changed
runtime/common/src/fee.rs
Outdated
| fn check_weight() { | ||
| let p = CENTS / 10; | ||
| let q = Balance::from(ExtrinsicBaseWeight::get().ref_time()); | ||
| // #[test] |
There was a problem hiding this comment.
Why is this test commented out? Should it be removed?
There was a problem hiding this comment.
Good question. I am working on getting the new values. The improvements in weights are causing this test to fail. I commented out so that I can run the weights.
There was a problem hiding this comment.
@mattheworris I wanted to follow up regarding the test we implemented to monitor improvements or regressions in the extrinsic weights. After reviewing it, I have updated the test to reflect the new range of weights based on the improvements observed.
We are not planning to make any changes to our fees at this time. However, please feel free to share your opinion.
mattheworris
approved these changes
Jun 20, 2024
| @@ -40,7 +40,7 @@ impl<Block: BlockT> HeaderBackend<Block> for TestApi { | |||
|
|
|||
| fn status( | |||
| &self, | |||
| _id: <Block as sp_api::BlockT>::Hash, | |||
| _id: Block::Hash, | |||
github-actions
bot
added
the
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.4.0-to-v1.5.0-issue-1813
branch
from
f147b27
to
43249ad
Compare
github-actions
bot
removed
the
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.4.0-to-v1.5.0-issue-1813
branch
from
49b8afb
to
c289442
Compare
github-actions
bot
added
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.4.0-to-v1.5.0-issue-1813
branch
from
c289442
to
30d9cda
Compare
github-actions
bot
added
metadata-changed
- Upgrade Polkadot-sdk to v.1.5.0. - Update weights to reflect the new version. - Modify extrinsic weight test due to a 25% improvement in weights. For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.5.0) [Release Analysis](https://forum.polkadot.network/t/polkadot-release-analysis-v1-5-0/5358) issue-1813
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.4.0-to-v1.5.0-issue-1813
branch
from
30d9cda
to
2333bf3
Compare
github-actions
bot
added
metadata-changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more details, please refer to:
Release Notes
Release Analysis
#1813