Temporarily remove dependency on frequenz-api-common
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
camille-bouvy-frequenz
force-pushed
the
remove-common-dependencies
branch
from
58036a2
to
05743bd
Compare
Signed-off-by: camille-bouvy-frequenz <camille.bouvy@frequenz.com>
camille-bouvy-frequenz
force-pushed
the
remove-common-dependencies
branch
from
05743bd
to
b767a6c
Compare
ci-agent-frequenz
approved these changes
Jan 23, 2024
matthias-wende-frequenz
approved these changes
Jan 23, 2024
camille-bouvy-frequenz
merged commit f5768a1
into
frequenz-floss:v0.x.x
16 checks passed
camille-bouvy-frequenz
added a commit
that referenced
this pull request
Feb 6, 2024
…files Revert #24: Remove files from `frequenz-api-common`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Electricity Trading API uses protobuf types location and pagination defined in
frequenz-api-commonv0.5.3. But Frequenz SDK v0.25 is not compatible with frequenz-api-common v0.5.0.For the Electricity Trading API client to be able to work with the SDK, this PR temporarily removes the dependency on
frequenz-api-common, and adds the definitions for the required proto files into this repo.This will be reverted once the SDK has been updated to use a newer version of frequenz-api-common.